Only ignore directories named build if they are in the root#44
Open
jeltz wants to merge 1 commit into
Open
Conversation
I do not think there is any good reason for having a build directory in a subdirectory, so limit the scope to ignore only exactly what we want to ignore.
Contributor
|
Is it just "/build" from the root of the OS filesystem? It is not a common practice to have a build directory in that place and it is outside of git tree as I understand. From the other hand, many IDEs just do builds inside of the tree in the "build" directory. |
Contributor
Author
|
No, by root I meant the root of the git repo. Starting paths with a slash whenever possible is a good practice in |
dutow
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not think there is any good reason for having a
builddirectory in a subdirectory, so limit the scope to ignore only exactly what we want to ignore.